feat: add schema tests for core clinical models#1302
Open
Hitendrasinhdata7 wants to merge 1 commit intotuva-health:mainfrom
Open
feat: add schema tests for core clinical models#1302Hitendrasinhdata7 wants to merge 1 commit intotuva-health:mainfrom
Hitendrasinhdata7 wants to merge 1 commit intotuva-health:mainfrom
Conversation
✅ Deploy Preview for thetuvaproject canceled.
|
|
Looks good. Adding schema tests for core models improves data quality and helps catch issues early. Follows the same pattern as previous PRs and makes the models more reliable. |
Collaborator
|
A YAML file for core models already exists here: https://github.com/tuva-health/tuva/blob/main/models/core/core_models.yml#L2136 Either update this PR to add additional tests to that file or close this PR please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds schema.yml with data quality tests for core clinical models
that were previously untested.
Models covered
Why
These models had no schema tests. Adding tests ensures
data quality and catches regressions early.
Related
Follows the same pattern as PR #1301